Add more documentation for the instrumentor base class#638
Merged
codeboten merged 7 commits intoopen-telemetry:masterfrom May 12, 2020
Merged
Add more documentation for the instrumentor base class#638codeboten merged 7 commits intoopen-telemetry:masterfrom
codeboten merged 7 commits intoopen-telemetry:masterfrom
Conversation
ocelotl
added
doc
toumorokoshi
suggested changes
May 3, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks for doing this! There's a couple areas I think that could be rewritten to be a bit more succinct, see comments.
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
c24t
approved these changes
May 11, 2020
lzchen
approved these changes
May 11, 2020
owais
pushed a commit
to owais/opentelemetry-python
that referenced
this pull request
May 22, 2020
…lemetry#638) Fixes open-telemetry#637 Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com> Co-authored-by: Chris Kleinknecht <libc@google.com>
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…pen-telemetry#638) * chore: fix renames in metrics test * chore: fix formatting * chore: rename BaseInstrument to BaseBoundInstrument Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #637